Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_virtual_hub_connection: fix acctest #7731

Merged
merged 1 commit into from
Jul 14, 2020
Merged

azurerm_virtual_hub_connection: fix acctest #7731

merged 1 commit into from
Jul 14, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jul 14, 2020 

💤 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS="-run='TestAccAzureRMVirtualHubConnection_complete'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run='TestAccAzureRMVirtualHubConnection_complete' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMVirtualHubConnection_complete
=== PAUSE TestAccAzureRMVirtualHubConnection_complete
=== CONT  TestAccAzureRMVirtualHubConnection_complete
--- PASS: TestAccAzureRMVirtualHubConnection_complete (1586.35s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       1586.394s

@ghost ghost added the size/XS label Jul 14, 2020
katbyte
katbyte approved these changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katbyte katbyte added this to the v2.19.0 milestone Jul 14, 2020
@tombuildsstuff tombuildsstuff merged commit 8a8a667 into hashicorp:master Jul 14, 2020
@tombuildsstuff tombuildsstuff added bug and removed tests labels Jul 14, 2020
tombuildsstuff added a commit that referenced this pull request Jul 14, 2020
@tombuildsstuff
updating to include #7731
1ba6383
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug service/virtual-hub size/XS
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@magodo @katbyte @tombuildsstuff